Skip to content

feat: add enrichment of StartRequest with OS, device ID, version #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 27, 2025
Merged

feat: add enrichment of StartRequest with OS, device ID, version #123

merged 4 commits into from
Mar 27, 2025

Conversation

spikecurtis
Copy link
Collaborator

@spikecurtis spikecurtis commented Mar 26, 2025 •
edited
Loading

Enriches StartRequest protocol message with device ID, OS, and version, for Coder Desktop telemetry.

@spikecurtis Graphite App
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@spikecurtis spikecurtis marked this pull request as ready for review March 26, 2025 12:46
ethanndickson
ethanndickson approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@ethanndickson ethanndickson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 after a make fmt

As an aside, I don't think we use pre-commit hooks anywhere at Coder, but it might be worth setting one up for fmt & lint?

EDIT: Also, we need to bump the version in the handshaker I believe?

@ethanndickson
Copy link
Member

ethanndickson commented Mar 26, 2025 •
edited
Loading

Don't we need to bump the proto version in the Handshaker?

@spikecurtis spikecurtis force-pushed the spike/telemetry-enrichment branch from 8b9a2a3 to 9da59a0 Compare March 27, 2025 06:34
@spikecurtis Graphite App
Copy link
Collaborator Author

spikecurtis commented Mar 27, 2025 •
edited
Loading

Merge activity

  • Mar 27, 2:54 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Mar 27, 2:54 AM EDT: A user merged this pull request with Graphite.

@spikecurtis spikecurtis merged commit d311dda into main Mar 27, 2025
4 checks passed
@spikecurtis spikecurtis deleted the spike/telemetry-enrichment branch March 27, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanndickson ethanndickson ethanndickson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spikecurtis @ethanndickson